haojin2 commented on a change in pull request #12035: Pad Operator Type Support
URL: https://github.com/apache/incubator-mxnet/pull/12035#discussion_r211146630
##########
File path: tests/python/unittest/test_operator.py
##########
@@ -2926,16 +2926,20 @@ def check_pad_with_shape(shape, xpu, pad_width, mode):
@with_seed()
def test_pad():
+ ctx = default_context()
shape1 = (2, 3, 3, 5)
pad1 = (0, 0, 0, 0, 1, 2, 3, 4)
shape2 = (2, 3, 3, 5, 4)
pad2 = (0, 0, 0, 0, 1, 2, 3, 4, 3, 1)
- check_pad_with_shape(shape1, default_context(), pad1, 'constant')
- check_pad_with_shape(shape1, default_context(), pad1, 'edge')
- check_pad_with_shape(shape2, default_context(), pad2, 'constant')
- check_pad_with_shape(shape2, default_context(), pad2, 'edge')
- check_pad_with_shape(shape1, default_context(), pad1, 'reflect')
- check_pad_with_shape(shape2, default_context(), pad2, 'reflect')
+ # note: this op doesn't support ints yet. Add tests when supported
+ test_types = ["float16", "float32", "float64"]
Review comment:
should be
```Python
dtypes = [np.float16, np.float32, np.float64]
```
?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
