nswamy commented on issue #11885: Fix JNI custom op code from deregistering the operator fixes #10438 URL: https://github.com/apache/incubator-mxnet/pull/11885#issuecomment-414832635 Thanks @andrewfayres for the detailed explanation. Next time please add the results also in the PR. What makes such PR hard is that we are basing off of manual tests which are not reproducible unless another person does the exact same manual test to verify. The concern I have in such cases is the possibility of introducing regressions somewhere else.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
