lebeg commented on a change in pull request #12308: [MKLDNN] Enable convolution
fusion.
URL: https://github.com/apache/incubator-mxnet/pull/12308#discussion_r212633347
##########
File path: src/operator/nn/convolution.cc
##########
@@ -41,11 +42,19 @@ static inline index_t AddPad(index_t dsize, index_t pad) {
}
static inline std::vector<std::string> ListArguments(const ConvolutionParam&
param_) {
- if (!param_.no_bias) {
+ if (!param_.no_bias)
return {"data", "weight", "bias"};
- } else {
+ else
return {"data", "weight"};
+}
+
+static inline std::string PrintArguments(const ConvolutionParam& param_) {
+ auto args = ListArguments(param_);
+ std::string str = "[";
Review comment:
It's better to use std::stringstream to compose such string, otherwise it's
a lot of redundant copying internally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
