KellenSunderland commented on a change in pull request #12333: WIP: Zombie fix
URL: https://github.com/apache/incubator-mxnet/pull/12333#discussion_r212659679
##########
File path: ci/build.py
##########
@@ -317,26 +454,32 @@ def use_cache():
logging.warning("Container was just built. Exiting due to
build-only.")
return 0
+ ret = 0
if command:
- container_run(platform=platform, docker_binary=docker_binary,
shared_memory_size=shared_memory_size,
- command=command,
docker_registry=args.docker_registry,
- local_ccache_dir=args.ccache_dir,
interactive=args.interactive)
+ ret = container_run(platform=platform,
nvidia_runtime=args.nvidiadocker,
+ shared_memory_size=args.shared_memory_size, command=command,
docker_registry=args.docker_registry,
+ local_ccache_dir=args.ccache_dir,
interactive=args.interactive, cleanup=cleanup)
elif args.print_docker_run:
- print(container_run(platform=platform,
docker_binary=docker_binary, shared_memory_size=shared_memory_size,
- command=[], dry_run=True,
docker_registry=args.docker_registry, local_ccache_dir=args.ccache_dir))
+ ret = container_run(platform=platform,
nvidia_runtime=args.nvidiadocker,
+ shared_memory_size=args.shared_memory_size, command=[],
dry_run=True, docker_registry=args.docker_registry,
+ local_ccache_dir=args.ccache_dir)
Review comment:
Should we pass cleanup here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
