luobao-intel commented on a change in pull request #12418: Fix flaky test:
test_mkldnn.test_activation #12377
URL: https://github.com/apache/incubator-mxnet/pull/12418#discussion_r214285519
##########
File path: tests/python/mkl/test_mkldnn.py
##########
@@ -292,7 +291,7 @@ def check_activation_training(stype):
in_location = [mx.nd.array(data_tmp).tostype(stype)]
test = mx.symbol.Activation(data, act_type="relu")
- check_numeric_gradient(test, in_location, numeric_eps=1e-2,
rtol=0.16, atol=1e-4)
+ check_numeric_gradient(test, in_location, numeric_eps=1e-6,
rtol=0.16, atol=1e-4)
Review comment:
This epsilon would have an impact on the baseline calculation instead of
mkldnn calculation. And the smaller the epsilon is, the more accurate the
baseline (gradient referring to theano) is. So this change won't make it worse.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
