This is an automated email from the ASF dual-hosted git repository.

anirudh2290 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git


The following commit(s) were added to refs/heads/master by this push:
     new 10e94f8  fixed flaky test issue for 
test_operator_gpu.test_convolution_grouping (#12385)
10e94f8 is described below

commit 10e94f8804ccde98a4edc12d0ed2e0b2014e41a9
Author: Manu Seth <22492939+mset...@users.noreply.github.com>
AuthorDate: Fri Aug 31 18:09:50 2018 -0700

    fixed flaky test issue for test_operator_gpu.test_convolution_grouping 
(#12385)
    
    * fixed flaky test issue for test_operator_gpu.test_convolution_grouping
    
    * Changed implicit cast to explicit cast
---
 tests/python/unittest/test_operator.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/tests/python/unittest/test_operator.py 
b/tests/python/unittest/test_operator.py
index 5bd88dd..78285b6 100644
--- a/tests/python/unittest/test_operator.py
+++ b/tests/python/unittest/test_operator.py
@@ -1583,7 +1583,6 @@ def test_batchnorm_training():
     check_batchnorm_training('default')
 
 
-@unittest.skip("Flaky test 
https://github.com/apache/incubator-mxnet/issues/12219";)
 @with_seed()
 def test_convolution_grouping():
     for dim in [1, 2, 3]:
@@ -1606,7 +1605,7 @@ def test_convolution_grouping():
         exe1 = y1.simple_bind(default_context(), x=shape)
         exe2 = y2.simple_bind(default_context(), x=shape, w=(num_filter, 
shape[1]//num_group) + kernel, b=(num_filter,))
         for arr1, arr2 in zip(exe1.arg_arrays, exe2.arg_arrays):
-            arr1[:] = np.random.normal(size=arr1.shape)
+            arr1[:] = np.float32(np.random.normal(size=arr1.shape))
             arr2[:] = arr1
         exe1.forward(is_train=True)
         exe1.backward(exe1.outputs[0])
@@ -1614,7 +1613,7 @@ def test_convolution_grouping():
         exe2.backward(exe2.outputs[0])
 
         for arr1, arr2 in zip(exe1.outputs + exe1.grad_arrays, exe2.outputs + 
exe2.grad_arrays):
-            np.testing.assert_allclose(arr1.asnumpy(), arr2.asnumpy(), 
rtol=1e-3, atol=1e-4)
+            np.testing.assert_allclose(arr1.asnumpy(), arr2.asnumpy(), 
rtol=1e-3, atol=1e-3)
 
 
 @unittest.skip("Flaky test 
https://github.com/apache/incubator-mxnet/issues/12203";)

Reply via email to