aaronmarkham edited a comment on issue #12168: Error in Operator implementation 
guide
URL: 
https://github.com/apache/incubator-mxnet/issues/12168#issuecomment-418555387
 
 
   I think I found the culprit. 
   The md-->html build when you do `make html` or `make docs` gives you things 
like `<gpu>` which renders fine in the browser. 
   
   There's a post-process step for building the versioned website that uses 
beautiful soup to inject the modified nav bar. It also has a step that swaps 
out the html tags for < and > with actual < and >.
   
https://github.com/apache/incubator-mxnet/blame/master/docs/build_version_doc/AddVersion.py#L77
   
   So, introduce this AddVersion.py script and it swaps it back to `<gpu>`. You 
can see this in the website static files that have gone through this process:
   
https://github.com/apache/incubator-mxnet-site/blob/asf-site/faq/add_op_in_backend.html#L751
   This does not render properly. This is the same thing happening with the 
scala tutorial: https://github.com/apache/incubator-mxnet/issues/11438
   
   I can remove that line, but I don't know why it's there in the first place. 
@piiswrong - you authored it... do you remember what it is for? Can we safely 
remove it, or provide a more focused implementation so it doesn't break the 
tags we're trying to put in there?
   
   **EDIT**: I commented [that 
line](https://github.com/apache/incubator-mxnet/blame/master/docs/build_version_doc/AddVersion.py#L77)
 out and reran the process on master, and the output is fixed. Not sure if 
something somewhere is broken though...
   http://34.201.8.176/versions/tag_render/faq/add_op_in_backend.html
   
![2018-09-04_17-27-28](https://user-images.githubusercontent.com/5974205/45064288-d0713400-b067-11e8-9b65-b429834a57e8.png)
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to