marcoabreu commented on a change in pull request #12458: Add extra check for
illegal case in reshape
URL: https://github.com/apache/incubator-mxnet/pull/12458#discussion_r215117381
##########
File path: tests/python/unittest/test_operator.py
##########
@@ -2109,6 +2109,10 @@ def test_reshape_new(src_shape, shape_args, reverse,
dst_shape):
'Output Shape = %s' %(str(holdout_src_shape), str(shape_args),
str(reverse),
str(dst_shape), str(output_shape[0]))
+ def test_invalid_reshape():
Review comment:
Can you remove the test_ prefix? It is reserved for top level functions that
are being tested
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
