jasonyu1996 commented on a change in pull request #12430: [MXNET-882] Support
for N-d arrays added to diag op.
URL: https://github.com/apache/incubator-mxnet/pull/12430#discussion_r216118642
##########
File path: src/operator/tensor/diag_op-inl.h
##########
@@ -133,13 +167,94 @@ struct diag_gen {
auto j = unravel(i, oshape);
if (j[1] == (j[0] + k)) {
Review comment:
`diag_gen` is what is reserved for generating 2D matrices from 1D inputs (a
functionality from the original `diag` operator). It would not be invoked when
the input has more than 1 dimension.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
