tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack
Transformation API
URL: https://github.com/apache/incubator-mxnet/pull/12047#discussion_r216173282
##########
File path: include/mxnet/ndarray.h
##########
@@ -831,7 +855,7 @@ class NDArray {
Chunk(const NDArrayStorageType storage_type_, const TBlob &data,
const std::vector<TBlob> &aux_data, int dev_id)
- : static_data(true), delay_alloc(false), storage_type(storage_type_) {
+ : static_data(true), delay_alloc(false), storage_type(storage_type_),
deleter_(nullptr) {
Review comment:
We cannot plug deleter to the TBlob and Chunk, this seems will cause more
problems than what it can solve.
std::shared_ptr<Chunk> do support customized deleter already, and maybe that
can be used to help solve this issue of having to hide a customized deleter for
NDArray
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
