lanking520 commented on a change in pull request #12489: [WIP] Symbol Random api
URL: https://github.com/apache/incubator-mxnet/pull/12489#discussion_r216185464
##########
File path:
scala-package/macros/src/main/scala/org/apache/mxnet/SymbolMacro.scala
##########
@@ -97,34 +117,41 @@ private[mxnet] object SymbolImplMacros {
val newSymbolFunctions = {
if (isContrib) symbolFunctions.filter(
func => func.name.startsWith("_contrib_") ||
!func.name.startsWith("_"))
- else symbolFunctions.filter(!_.name.startsWith("_"))
+ else symbolFunctions.filter(f => !f.name.startsWith("_") &&
Review comment:
Let's think of how we can move the filter method out of this `typedAPIImpl`.
So different method generator pass in different filters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
