samskalicky commented on a change in pull request #12430: [MXNET-882] Support for N-d arrays added to diag op. URL: https://github.com/apache/incubator-mxnet/pull/12430#discussion_r217109852
########## File path: src/operator/tensor/diag_op-inl.h ########## @@ -104,42 +143,132 @@ inline bool DiagOpType(const nnvm::NodeAttrs& attrs, return (*out_attrs)[0] != -1; } -template<int req> +template<int ndim, int req, bool back> Review comment: should ndim here be index_t too? or maybe im going to far with the index_t.... ;-) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
