reminisce commented on a change in pull request #11641: [MXNET-876] make
CachedOp a normal operator
URL: https://github.com/apache/incubator-mxnet/pull/11641#discussion_r217187955
##########
File path: src/imperative/cached_op.cc
##########
@@ -1067,34 +1067,140 @@ void CachedOp::Backward(
Engine::Get()->set_bulk_size(prev_bulk_size);
}
-bool CachedOp::ForwardStorageType(const nnvm::NodeAttrs& attrs,
- const int dev_mask,
- DispatchMode* dispatch_mode,
- std::vector<int> *in_attrs,
- std::vector<int> *out_attrs) {
- using namespace imperative;
- nnvm::Graph g(fwd_graph_);
- const auto& idx = g.indexed_graph();
- const auto &outputs = idx.outputs();
+/*
+ * This is the operator state of CachedOp when CachedOp is used in the symbol
Review comment:
Please elaborate on the necessity of adding this data structure in the
description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
