jasonyu1996 commented on issue #12430: [MXNET-882] Support for N-d arrays added to diag op. URL: https://github.com/apache/incubator-mxnet/pull/12430#issuecomment-421011164 @samskalicky @apeforest It seems that `dim_t` is poisonous in some cases. I have changed to following examples. `k` changed to `int` following the old `diag` implementation, `axis1` and `axis2` changed to `int32_t` following `swapaxes` and `concat`. I notice this is actually not very consistent in different operator implementations, and believe that if one day it is necessary to have a tensor of that many dimensions, these operators might have to go through some refactoring work.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
