lebeg commented on a change in pull request #12560: fix test_activation by
lowering threshold + validate eps for check_numeric_gradient
URL: https://github.com/apache/incubator-mxnet/pull/12560#discussion_r217988369
##########
File path: tests/python/mkl/test_mkldnn.py
##########
@@ -292,7 +291,7 @@ def check_activation_training(stype):
in_location = [mx.nd.array(data_tmp).tostype(stype)]
test = mx.symbol.Activation(data, act_type="relu")
- check_numeric_gradient(test, in_location, numeric_eps=1e-2,
rtol=0.16, atol=1e-4)
+ check_numeric_gradient(test, in_location, numeric_eps=1e-5,
rtol=0.16, atol=1e-4)
Review comment:
Ok, thanks for the explanation!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
