apeforest commented on a change in pull request #12558: [MXNET-952] Check for 
correlation kernel size along with unittest
URL: https://github.com/apache/incubator-mxnet/pull/12558#discussion_r218138022
 
 

 ##########
 File path: tests/python/unittest/test_operator.py
 ##########
 @@ -6913,6 +6913,16 @@ def test_invalid_depth_dim():
     test_invalid_block_size()
     test_invalid_depth_dim()
 
+@with_seed()
+def test_invalid_kernel_size():
+    invalid_kernel_size = 28
+    
assert_exception(mx.nd.Correlation,MXNetError,mx.nd.array(np.random.rand(1, 1, 
28, 28)),mx.nd.array(np.random.rand(1, 1, 28, 
28)),kernel_size=invalid_kernel_size)
 
 Review comment:
   nit: break the long line.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to