anirudhacharya commented on a change in pull request #12572: Make Gluon
download function to be atomic
URL: https://github.com/apache/incubator-mxnet/pull/12572#discussion_r218221596
##########
File path: python/mxnet/gluon/utils.py
##########
@@ -195,6 +197,39 @@ def check_sha1(filename, sha1_hash):
return sha1.hexdigest() == sha1_hash
+if sys.platform != 'win32':
+ # refer to https://github.com/untitaker/python-atomicwrites
+ def _replace_atomic(src, dst):
+ """Implement atomic os.replace with linux and OSX. Internal Usa only"""
+ os.rename(src, dst)
Review comment:
can you put this in a try catch block to handle `OSError`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
