andrewfayres commented on a change in pull request #12536: [MXNET-913][WIP] Java API --- Scala NDArray Improvement URL: https://github.com/apache/incubator-mxnet/pull/12536#discussion_r218268887
########## File path: scala-package/core/src/main/scala/org/apache/mxnet/api/java/ArgBuilder.scala ########## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.mxnet.api.java + +import scala.collection.mutable +import scala.collection.mutable.ListBuffer +import collection.JavaConverters._ + +/** + * This arg Builder is intent to solve Java to Scala conversion + * to take the input such as (arg: Any*) + */ +class ArgBuilder { Review comment: So about 10% of NDArray methods have more than 3 default args. I'm going to give some more thought before I commit to this but my initial reaction is that we include this but try not to promote it's use too much in docs/examples. Leave it there as an ease of use option for the customer with the understanding that when they use this they will be giving up type-safety. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
