KellenSunderland commented on issue #12499: [MXNET-922] Fix memleak in profiler URL: https://github.com/apache/incubator-mxnet/pull/12499#issuecomment-422261391 Good point Anton, thanks. I'll double check just to be sure it's not needed. On Mon, Sep 17, 2018, 4:44 AM Anton Chernov <[email protected]> wrote: > *@lebeg* approved this pull request. > ------------------------------ > > In src/profiler/profiler.h > <https://github.com/apache/incubator-mxnet/pull/12499#discussion_r217986833> > : > > > @@ -455,7 +455,7 @@ class Profiler { > /*! \brief filename to output profile file */ > std::string filename_ = "profile.json"; > /*! \brief profile statistics consist of multiple device statistics */ > - DeviceStats* profile_stat; > + std::unique_ptr<DeviceStats[], std::default_delete<DeviceStats[]>> profile_stat; > > std::default_delete<DeviceStats[]> is default and not needed explicitly, > I think > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-mxnet/pull/12499#pullrequestreview-155824809>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AHGTEyHAcAMM20gltWP2DUxI2CDpFHPJks5ub2DhgaJpZM4Whorh> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
