KellenSunderland commented on a change in pull request #12550: [MXNET-908] Enable python tests in Travis URL: https://github.com/apache/incubator-mxnet/pull/12550#discussion_r218547006
########## File path: .travis.yml ########## @@ -29,3 +29,4 @@ script: - export MXNET_STORAGE_FALLBACK_LOG_VERBOSE=0 - mv make/osx.mk config.mk - make -j 2 Review comment: I think it would be great if we could add Scala tests as well, but I do have a few concerns. How long would they take to execute? Let's keep in mind that we have a limited number of executors that can be run before we begin interfering with other Apache projects. There's also a global timeout of ~45 minutes to build and execute on a virtualized MacOS host which takes a few minutes just to start. I'd ideally like to keep our total test time below 30 minutes to avoid hitting this in the future. In principle I'm not against build stages, but unless we have a lot of jobs running in parallel that have dependencies on each other I don't see a big benefit in using them. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
