haojin2 commented on a change in pull request #12594: [MXNET-867] Pooling1D
with "same" padding
URL: https://github.com/apache/incubator-mxnet/pull/12594#discussion_r219257516
##########
File path: tests/python/unittest/test_operator.py
##########
@@ -6957,6 +6957,17 @@ def test_invalid_depth_dim():
test_invalid_block_size()
test_invalid_depth_dim()
+@with_seed()
+def test_max_pooling_pad_type_same():
+ input_data=mx.nd.array(np.random.rand(1,1,10))
+ output_data=mx.nd.Pooling(
+ input_data,
+ kernel=(2),
Review comment:
@ChaiBapchya You should add checks for illegal inputs that are not supported
by your implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
