apeforest commented on a change in pull request #12603: [MXNET-969] Fix buffer
overflow in RNNOp
URL: https://github.com/apache/incubator-mxnet/pull/12603#discussion_r219286106
##########
File path: src/operator/rnn-inl.h
##########
@@ -576,7 +583,7 @@ class RNNOp : public Operator{
req[rnn_enum::kData],
req[rnn_enum::kParams],
req[rnn_enum::kState],
- req[rnn_enum::kStateCell],
+ req_statecell,
Review comment:
Use conditional operator here to make code more concise:
`param_.mode == rnn_enum::kLstm ? req[rnn_enum::kStateCell] : NULL `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
