sandeep-krishnamurthy commented on a change in pull request #12622: Gluon DataLoader: avoid recursionlimit error URL: https://github.com/apache/incubator-mxnet/pull/12622#discussion_r219623092
########## File path: tests/python/unittest/test_gluon_data.py ########## @@ -75,24 +75,35 @@ def test_recordimage_dataset(): @with_seed() def test_recordimage_dataset_with_data_loader_multiworker(): - # This test is pointless on Windows because Windows doesn't fork - if platform.system() != 'Windows': - recfile = prepare_record() - dataset = gluon.data.vision.ImageRecordDataset(recfile) - loader = gluon.data.DataLoader(dataset, 1, num_workers=5) - - for i, (x, y) in enumerate(loader): - assert x.shape[0] == 1 and x.shape[3] == 3 - assert y.asscalar() == i - - # with transform - fn = lambda x, y : (x, y) - dataset = gluon.data.vision.ImageRecordDataset(recfile).transform(fn) - loader = gluon.data.DataLoader(dataset, 1, num_workers=5) - - for i, (x, y) in enumerate(loader): - assert x.shape[0] == 1 and x.shape[3] == 3 - assert y.asscalar() == i + recfile = prepare_record() + dataset = gluon.data.vision.ImageRecordDataset(recfile) + loader = gluon.data.DataLoader(dataset, 1, num_workers=5) + + for i, (x, y) in enumerate(loader): + assert x.shape[0] == 1 and x.shape[3] == 3 + assert y.asscalar() == i + + # with transform + fn = lambda x, y : (x, y) + dataset = gluon.data.vision.ImageRecordDataset(recfile).transform(fn) + loader = gluon.data.DataLoader(dataset, 1, num_workers=5) + + for i, (x, y) in enumerate(loader): + assert x.shape[0] == 1 and x.shape[3] == 3 + assert y.asscalar() == i + + # try limit recursion depth + import sys + old_limit = sys.getrecursionlimit() + sys.setrecursionlimit(100) # this should be smaller than any default value used in python + fn = lambda x, y : (x, y) + dataset = gluon.data.vision.ImageRecordDataset(recfile).transform(fn) + loader = gluon.data.DataLoader(dataset, 1, num_workers=5) + + for i, (x, y) in enumerate(loader): + assert x.shape[0] == 1 and x.shape[3] == 3 + assert y.asscalar() == i + sys.setrecursionlimit(old_limit) Review comment: yeah, you are right, I was thinking like a regular user functionality not like a unit test. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
