Roshrini commented on a change in pull request #12633: Onnx version update from
1.2.1 to 1.3 in CI
URL: https://github.com/apache/incubator-mxnet/pull/12633#discussion_r219928422
##########
File path: python/mxnet/contrib/onnx/mx2onnx/_op_translations.py
##########
@@ -64,11 +64,11 @@
def import_onnx_modules():
""" To make sure ONNX is runtime dependency, it is imported used only when
needed"""
try:
- from onnx import helper, numpy_helper, mapping
+ from onnx import helper, numpy_helper, mapping, TensorProto
Review comment:
here functions are invoked according to the operators in the model.. so try
catch with import statement doesn't work if you just do it at the top. You will
have to import with try catch in every method, so this way seems much better
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
