sxjscience commented on issue #12446: [WIP][Bugfix] Fix flaky topk URL: https://github.com/apache/incubator-mxnet/pull/12446#issuecomment-424430118 Sorry I have no time to look at this until Oct 3rd. Need to review lots of AAAI papers + Submit my final thesis. I’ll try to solve it after Oct 3rd. Get Outlook for iOS<https://aka.ms/o0ukef> ________________________________ From: Vandana Kannan <[email protected]> Sent: Wednesday, September 26, 2018 1:22:11 AM To: apache/incubator-mxnet Cc: Xingjian SHI; Mention Subject: Re: [apache/incubator-mxnet] [WIP][Bugfix] Fix flaky topk (#12446) @vandanavk commented on this pull request. ________________________________ In src/operator/tensor/ordering_op-inl.h<https://github.com/apache/incubator-mxnet/pull/12446#discussion_r220280496>: > @@ -455,8 +457,7 @@ void TopKImpl(const RunContext &ctx, // Cast `ret_indices` from int to real_t could introduce conversion error when the element_num // is large enough. if (param.ret_typ == topk_enum::kReturnMask) { - Tensor<xpu, 2, DType> ret_mask = - ret[0].get_with_shape<xpu, 2, DType>(Shape2(ret[0].Size(), 1), s); + Tensor<xpu, 1, DType> ret_mask = ret[0].FlatTo1D<xpu, DType>(s); ret_mask = scalar<DType>(0); @sxjscience<https://github.com/sxjscience> were you able to resolve the error? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://github.com/apache/incubator-mxnet/pull/12446#discussion_r220280496>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AE8D7rj7e2PpZWbaBO4RYxend_Yz_hcpks5uemZDgaJpZM4WX1yr>.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
