yuxihu commented on issue #12403: roi_align.cc bug? URL: https://github.com/apache/incubator-mxnet/issues/12403#issuecomment-424529755 > Besides, > #line 63-65 > const T yy = roi_start_h + ph * bin_size_h + > static_cast(iy + .5f) * bin_size_h / > static_cast(roi_bin_grid_h); > should be: > const T yy = roi_start_h + ph * bin_size_h + > static_cast(iy ) * bin_size_h / > static_cast(roi_bin_grid_h); > > #line 67-69 > > const T xx = roi_start_w + pw * bin_size_w + > static_cast(ix + .5f) * bin_size_w / > static_cast(roi_bin_grid_w); > > should be: > const T xx = roi_start_w + pw * bin_size_w + > static_cast(ix) * bin_size_w / > static_cast(roi_bin_grid_w); @eli2014: regarding your above comment, could you please also elaborate on why you think the code needs to be modified to what you suggested?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
