ZhennanQin commented on a change in pull request #12530: Implement mkldnn
convolution fusion and quantization.
URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r220414425
##########
File path: src/operator/quantization/quantize_graph_pass.cc
##########
@@ -199,33 +245,45 @@ Graph QuantizeGraph(Graph &&src) {
// the new_node.
*new_node = *node;
new_node->inputs.clear();
- for (const auto& e : node->inputs) {
- NodePtr mirror_node = mirror_map.at(e.node.get());
- NodeEntry mirror_entry = NodeEntry{
- mirror_node, e.index, e.version};
- // if input node is quantized operator, add dequantize node
- if (NeedQuantize(e.node, excluded_nodes)) {
- // here we calculate the output number (exclude min/max, in order to
- // calculate min/max index from mirror node) based on assumption that
- // there is only 1min and 1max output from mirror node (which is
- // currently true)
- size_t num_outputs = mirror_node->num_outputs() - 2;
- uint32_t min_index = num_outputs + 2 * e.index;
- uint32_t max_index = num_outputs + 2 * e.index + 1;
- NodePtr dequantize_node = CreateNode("_contrib_dequantize",
- e.node->attrs.name + "_dequantize");
- dequantize_node->inputs.emplace_back(mirror_entry);
- dequantize_node->inputs.emplace_back(NodeEntry{mirror_node,
min_index, 0});
- dequantize_node->inputs.emplace_back(NodeEntry{mirror_node,
max_index, 0});
- dequantize_node->op()->attr_parser(&(dequantize_node->attrs));
+ if (node->is_variable() && node->attrs.name == "data") {
Review comment:
This is to solve first layer calibration problem. If we try to quantize
first layer(eg. conv0), then we will insert an quantize op between data and
conv0. After enabling calib_quantize_op, we will collect calibration info on
data, which can't be done by set_monitor_callback as it only monitors op's
output, but data is not an output of any op. To solve this problem, we insert
an identity op for data, to convert it to identity's output, then we can use
set_monitor_callback to do calibration for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
