StOnEGiggity commented on issue #12660: fix bug in prelu , issue 12061 URL: https://github.com/apache/incubator-mxnet/pull/12660#issuecomment-424946457 @ChaiBapchya Thanks for reviewing. 1. The original unit test case with shape ``[3,4]`` could not check computation error as #12061 said. Suppose that our input shape is ``[N,C,H,W]``, gamma shape is ``[C,]``, we expect gamma shape like ``[1,C,1,1]`` rather than ``[1,1,C,1]`` . This error will occur when ``C`` has the same value as ``H``. 2. Same reason as 1. In my view, if i > 1, it corresponds to ``H`` or ``W``. I know it may not be appropriate to fix the dimension. It may be the simplest solution.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
