mbrookhart commented on a change in pull request #12502: [NGRAPH] MXNet -
nGraph initial integration
URL: https://github.com/apache/incubator-mxnet/pull/12502#discussion_r220786012
##########
File path: include/mxnet/ndarray.h
##########
@@ -783,6 +792,11 @@ class NDArray {
/*! This is created when data is stored in MKLDNN format.
*/
std::shared_ptr<MKLDNNMemory> mkl_mem_;
+#endif
+#if MXNET_USE_NGRAPH == 1
+ /*! this is set if ngraph tensorview is associated with this ndarray
+ */
+ std::shared_ptr<ngraph::runtime::TensorView> tensor_view_;
Review comment:
This is needed to get performance on backends other than GPU in Imperative
Gluon (think MKLDNN layouts or non CPU/non GPU memory). We're not including
these other backends in this first PR, and we haven't fully optimized Gluon for
CPU through nGraph, but this is setting the stage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
