reminisce commented on a change in pull request #12502: [NGRAPH] MXNet - nGraph
initial integration
URL: https://github.com/apache/incubator-mxnet/pull/12502#discussion_r221113044
##########
File path: src/executor/graph_executor.cc
##########
@@ -1590,7 +1590,7 @@ Executor *Executor::SimpleBind(nnvm::Symbol symbol,
std::unordered_map<std::string, NDArray>*
shared_buffer,
Executor* shared_exec) {
auto exec = new exec::GraphExecutor();
- if (!exec->subgraph_property().empty()) {
+ if (!exec->subgraph_property().empty() && group2ctx.empty()) {
Review comment:
It's better to give a warning message here for better user experience. Same
for the other place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
