aaronmarkham commented on a change in pull request #12689: Search update
URL: https://github.com/apache/incubator-mxnet/pull/12689#discussion_r221365578
##########
File path: docs/_static/js/docversion.js
##########
@@ -1,17 +1,17 @@
function setVersion(){
- let doc = window.location.pathname.match(/^\/(api\/.*)$/) ||
window.location.pathname.match(/^\/versions\/[^*]+\/(api\/.*)$/);
+ let doc =
window.location.pathname.match(/^\/versions\/[0-9.master]+\/([^*]+.*)$/);
Review comment:
Yep... good catch... I was testing the other side of the use case.
I've been thinking about a related point. I could just force all the default
traffic to /versions/master. This would solve a variety of thorny issues. Also,
help with analytics. WDYT about that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
