KellenSunderland commented on issue #12631: [MXNET-953] Fix oob memory read URL: https://github.com/apache/incubator-mxnet/pull/12631#issuecomment-425686158 Thanks for continuing to give feedback @lebeg. The pros I see for that approach: * Handles OOB * Works for various dest tensor types * Casts the void pointer to the correct type and assigns, which I think should be the correct way to deal with this. Cons: * Not super concise and a little difficult to read. I think I'm still slightly in favour of the current fix. Not sure if this is perf critical code so my bias would be towards readability and correctness here. This is my weak preference though, I'd also be fine with your approach.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
