lebeg commented on a change in pull request #11742: [MXNET-623] Fixing an integer overflow bug in large NDArray URL: https://github.com/apache/incubator-mxnet/pull/11742#discussion_r222146174
########## File path: tests/nightly/test_large_array.py ########## @@ -0,0 +1,31 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import mxnet as mx +from mxnet import gluon, nd + +def test_ndarray2numpy(): + m = gluon.nn.Embedding(14000, 128) + m.initialize() + ind = nd.zeros((700000, 128)) + x = m(ind) + x.shape + test=x.asnumpy() + assert (x.shape == test.shape) + +if __name__ == '__main__': + test_ndarray2numpy() Review comment: Well, my suggestion is more about the python code style, where to put it is another topic. Event if it would be a nightly test, you still want to have it in a good shape. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
