gigasquid closed pull request #12726: Fix failing GPU test on single GPU host (kvstore) #10977 URL: https://github.com/apache/incubator-mxnet/pull/12726
This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/tests/python/gpu/test_kvstore_gpu.py b/tests/python/gpu/test_kvstore_gpu.py index 5e9b120f14e..4232a590a5d 100644 --- a/tests/python/gpu/test_kvstore_gpu.py +++ b/tests/python/gpu/test_kvstore_gpu.py @@ -58,6 +58,7 @@ def init_kv_with_str(stype='default', kv_type='local'): # Test seed 89411477 (module seed 1829754103) resulted in a py3-gpu CI runner core dump. # Not reproducible, so this test is back on random seeds. @with_seed() [email protected](mx.context.num_gpus() < 2, "test_rsp_push_pull needs more than 1 GPU") def test_rsp_push_pull(): def check_rsp_push_pull(kv_type, sparse_pull, is_push_cpu=True): kv = init_kv_with_str('row_sparse', kv_type) @@ -65,7 +66,8 @@ def check_rsp_push_pull(kv_type, sparse_pull, is_push_cpu=True): push_ctxs = [mx.cpu(i) if is_push_cpu else mx.gpu(i) for i in range(2)] kv.push('e', [mx.nd.ones(shape, ctx=context).tostype('row_sparse') for context in push_ctxs]) - def check_rsp_pull(kv, count, ctxs, sparse_pull, is_same_rowid=False, use_slice=False): + def check_rsp_pull(kv, ctxs, sparse_pull, is_same_rowid=False, use_slice=False): + count = len(ctxs) num_rows = shape[0] row_ids = [] all_row_ids = np.arange(num_rows) @@ -100,14 +102,14 @@ def check_rsp_pull(kv, count, ctxs, sparse_pull, is_same_rowid=False, use_slice= expected_val[:] = 2 assert_almost_equal(retained, expected_val) - check_rsp_pull(kv, 1, [mx.gpu(0)], sparse_pull) - check_rsp_pull(kv, 1, [mx.cpu(0)], sparse_pull) - check_rsp_pull(kv, 4, [mx.gpu(i//2) for i in range(4)], sparse_pull) - check_rsp_pull(kv, 4, [mx.gpu(i//2) for i in range(4)], sparse_pull, is_same_rowid=True) - check_rsp_pull(kv, 4, [mx.cpu(i) for i in range(4)], sparse_pull) - check_rsp_pull(kv, 4, [mx.cpu(i) for i in range(4)], sparse_pull, is_same_rowid=True) - check_rsp_pull(kv, 4, [mx.gpu(i//2) for i in range(4)], sparse_pull, use_slice=True) - check_rsp_pull(kv, 4, [mx.cpu(i) for i in range(4)], sparse_pull, use_slice=True) + check_rsp_pull(kv, [mx.gpu(0)], sparse_pull) + check_rsp_pull(kv, [mx.cpu(0)], sparse_pull) + check_rsp_pull(kv, [mx.gpu(i//2) for i in range(4)], sparse_pull) + check_rsp_pull(kv, [mx.gpu(i//2) for i in range(4)], sparse_pull, is_same_rowid=True) + check_rsp_pull(kv, [mx.cpu(i) for i in range(4)], sparse_pull) + check_rsp_pull(kv, [mx.cpu(i) for i in range(4)], sparse_pull, is_same_rowid=True) + check_rsp_pull(kv, [mx.gpu(i//2) for i in range(4)], sparse_pull, use_slice=True) + check_rsp_pull(kv, [mx.cpu(i) for i in range(4)], sparse_pull, use_slice=True) envs = ["","1"] key = "MXNET_KVSTORE_USETREE" ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
