ChaiBapchya commented on a change in pull request #12749: [MXNET-1029] Feature 
request: randint operator
URL: https://github.com/apache/incubator-mxnet/pull/12749#discussion_r223222735
 
 

 ##########
 File path: tests/python/unittest/test_operator.py
 ##########
 @@ -7009,6 +7009,13 @@ def test_invalid_max_pooling_pad_type_same():
         name='pooling',
         pooling_convention="same")
 
+@with_seed()
+def test_randint():
+    a=mx.nd.random.randint(dtype='int8',low=-5,high=0)
 
 Review comment:
   Does every test need to necessarily have an assert? With random function 
testing, how do I test it anyway? One possible thing I can do is ensure that 
output is
   a. int (of the dtype that's mentioned in the param or int32 (default))
   b. within the low and high bounds
   
   Is that what you are referring?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to