ZhennanQin commented on a change in pull request #12530: Implement mkldnn
convolution fusion and quantization.
URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r223241107
##########
File path: src/operator/subgraph/subgraph_property.h
##########
@@ -92,6 +92,22 @@ class SubgraphProperty {
// execute the operators in the subgraph.
virtual nnvm::NodePtr CreateSubgraphNode(const nnvm::Symbol &s,
const int subgraph_id = 0) const =
0;
+ // Connect subgraph internal output with external output entries. By default,
+ // each output entry will connect to an unique internal output.
+ virtual void ConnectSubgraphOutputs(
+ const nnvm::NodePtr n,
Review comment:
@reminisce Code style is not consistent in this file. SubgraphSelector use
different coding style with SubgraphProperty, which making me confusing which
coding style should to follow. For example, SubgraphSelector uses /*! */ style
comment with param description, and long parameter name(eg nnvm::Node
&input_node), while SubgraphProperty uses \\ style comment without param
description, and short parameter name(eg. const nnvm::Symbol &s).
Changing these 2 SubgraphProperty functions into SubgraphSelector style
doesn't make sense to me. If you insist, I'd like to adjust the code style for
whole file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
