andrewfayres commented on a change in pull request #12757: [MXNET-915] Java Inference API core wrappers and tests URL: https://github.com/apache/incubator-mxnet/pull/12757#discussion_r223513632
########## File path: scala-package/core/src/main/scala/org/apache/mxnet/javaapi/DType.scala ########## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.mxnet.javaapi Review comment: So it appears that in Scala that all subpackages are in the namespace of the package. So in this case, the package org.apache.mxnet.java would be in the namespace for all of org.apache.mxnet. This leads to obvious issues when trying to call anything from the java library because all calls to java.foo.bar would be looking in the org.apache.mxnet.java namespace instead of the java library namespace. You could use _root_.java.foo.bar to get around this but I don't believe it's worth the headache. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
