xinyu-intel commented on a change in pull request #12724: simplify mac mkldnn build URL: https://github.com/apache/incubator-mxnet/pull/12724#discussion_r224648857
########## File path: MKLDNN_README.md ########## @@ -70,24 +69,10 @@ git clone --recursive https://github.com/apache/incubator-mxnet.git cd incubator-mxnet ``` -### Enable OpenMP for MacOS - -If you want to enable OpenMP for better performance, you should modify the Makefile in MXNet root dictionary: - -Add CFLAGS '-fopenmp' for Darwin. - -``` -ifeq ($(USE_OPENMP), 1) -# ifneq ($(UNAME_S), Darwin) - CFLAGS += -fopenmp -# endif -endif -``` - ### Build MXNet with MKL-DNN ``` -make -j $(sysctl -n hw.ncpu) CC=gcc-4.9 CXX=g++-4.9 USE_OPENCV=0 USE_OPENMP=1 USE_MKLDNN=1 USE_BLAS=apple USE_PROFILER=1 +LIBRARY_PATH=$(brew --prefix llvm)/lib/ make -j $(sysctl -n hw.ncpu) CC=$(brew --prefix llvm)/bin/clang++ CXX=$(brew --prefix llvm)/bin/clang++ USE_OPENCV=0 USE_OPENMP=1 USE_MKLDNN=1 USE_BLAS=apple USE_PROFILER=1 ``` *Note: Temporarily disable OPENCV.* Review comment: Please remove this line since llvm support opencv well now. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
