marcoabreu commented on issue #12094: [MXNET-793] ★ Virtualized testing in CI 
with QEMU ★
URL: https://github.com/apache/incubator-mxnet/pull/12094#issuecomment-430236202
 
 
   I think such a refactor is slightly out of context for this PR as the 
intention is to add QEMU support. Refactors should be done and discussed 
separately.
   
   The reason I'm opposed to renaming files is that the references are not only 
within this repository but also other people who actually clone it and do 
things on top of it - that's always something we have to consider in an open 
source project. We can't scan for these occasions so I'd rather err on the side 
of caution here. We could have a separate PR and create a lazy-vote on dev@ to 
ensure everybody is aware of this change and that they have a possibility to 
speak up. WDYT?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to