lebeg commented on issue #12784: Improved git reset for CI builds
URL: https://github.com/apache/incubator-mxnet/pull/12784#issuecomment-430242038
 
 
   > Do you have an example of such a case?
   
   We recently had a problem with some buildscripts that would [modify some 
Makefiles](https://github.com/apache/incubator-mxnet/pull/11245/files#diff-1335fbaf3930b1438d9be18edb07a1a6R73)
 for Jetson cross compilation.
   
   > The problem with your PR is that it's actually purging too much and 
putting the repository into a "too" clean state. It's effectively invalidating 
Jenkins' actions.
   
   I'm afraid I don't understand what is a "too clean" state. What actions of 
Jenkins we are invalidating? What situation we are trying to validate by not 
resetting the repository before a clean build? 
   
   > ... revert this merge and effectively switch from a "PR-merge" to a 
"PR-head" strategy.
   
   We try to merge a PR into not modified master state. We are not switching 
any strategies, nor moving `HEAD` in any way.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to