mbrookhart commented on a change in pull request #12502: [NGRAPH] MXNet - 
nGraph initial integration
URL: https://github.com/apache/incubator-mxnet/pull/12502#discussion_r225991117
 
 

 ##########
 File path: Makefile
 ##########
 @@ -74,8 +75,10 @@ endif
 include $(TPARTYDIR)/mshadow/make/mshadow.mk
 include $(DMLC_CORE)/make/dmlc.mk
 
-# all tge possible warning tread
-WARNFLAGS= -Wall -Wsign-compare
+include 3rdparty/ngraph-mxnet-bridge/ngraph.mk
 
 Review comment:
   Hi @eric-haibin-lin, nGraph and direct MKLDNN integration are using 
different versions of MKLDNN right now. We do have a branch that can build them 
together, but we thought it would be better to isolate nGraph for initial 
experimental use. We're working internally to align release schedules over the 
next couple of quarters, so we should be able to align in the next quarter or 
so.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to