piyushghai commented on a change in pull request #12848: Fix Batch input issue 
with Scala Benchmark
URL: https://github.com/apache/incubator-mxnet/pull/12848#discussion_r226014840
 
 

 ##########
 File path: 
scala-package/examples/src/main/scala/org/apache/mxnetexamples/InferBase.scala
 ##########
 @@ -21,7 +21,7 @@ import org.apache.mxnet._
 
 trait InferBase {
 
-  def loadModel(context: Array[Context]): Any
+  def loadModel(context: Array[Context], batchInference : Boolean): Any
 
 Review comment:
   The examples still remain stand alone. The InferBase utility is only used, 
if one wants to measure the performance of a particular model in Scala using 
the inference APIs. 
   That way they would not have to dig into the examples and add the metrics in 
each example. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to