lanking520 commented on issue #12690: [MXNET-1000] get Ndarray real value and 
form it from a NDArray
URL: https://github.com/apache/incubator-mxnet/pull/12690#issuecomment-430712239
 
 
   > IMO, It still doesn't warrant to add this , whether you call it visualize 
or override toString. Another thing its confusing user experience that you are 
putting arbitrary THRESHOLD values?. what makes these values to be correct, why 
not more or less.
   > 
   > ```
   >     val ARRAYTHRESHOLD = 1000   // longest array to show in full 
   > ```
   @nswamy since this is just a helper tool for users to debug and see what 
content inside. I think it's fair to have this tool. This Threshold value is 
just a limitation on numbers of elements to be shown in the array. The reason I 
set it as 1000 because 10000 sometimes would crash the JVM because it used too 
much memory and it's making no sense for a user to visualize that much. If the 
user seriously wants something to show up, he/she should at least try to slice 
and get it visualized. We can get this threshold configurable and ask the user 
to pass in. I am also curious how numpy set up this number in Python. If I can 
find a number in there I will let you know.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to