apeforest commented on a change in pull request #12031: Fix CPUPinned
unexpected behaviour
URL: https://github.com/apache/incubator-mxnet/pull/12031#discussion_r226126856
##########
File path: src/storage/storage.cc
##########
@@ -51,7 +51,13 @@ class StorageImpl : public Storage {
static void ActivateDevice(Context ctx) {
Review comment:
This method should not be static. It is not protected by any RAII object.
Besides, it is not used by any other classes anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
