andrewfayres commented on a change in pull request #12848: Fix Batch input
issue with Scala Benchmark
URL: https://github.com/apache/incubator-mxnet/pull/12848#discussion_r226128465
##########
File path: scala-package/core/src/main/scala/org/apache/mxnet/Shape.scala
##########
@@ -34,6 +34,7 @@ class Shape(dims: Traversable[Int]) extends Serializable {
def size: Int = shape.size
def length: Int = shape.length
def drop(dim: Int): Shape = new Shape(shape.drop(dim))
+ def dropBack(dim : Int) : Shape = new Shape(shape.dropRight(dim))
Review comment:
I agree name isn't intuitive. If we were going to introduce this I'd say we
call it dropRight to keep in line with Scala's naming.
With that said, I don't think we need this API. I don't see you using it
anywhere and I think someone could just use slice to do this quite easily.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
