anirudhacharya commented on a change in pull request #12853: Add GN
URL: https://github.com/apache/incubator-mxnet/pull/12853#discussion_r226180425
##########
File path: python/mxnet/gluon/nn/basic_layers.py
##########
@@ -700,3 +701,82 @@ def hybrid_forward(self, F, x, *args):
def __repr__(self):
return '{name}({function})'.format(name=self.__class__.__name__,
function=self._func_name)
+
+
+class GroupNorm(Block):
+ """GroupNorm normalization layer (Wu and He, 2014).
Review comment:
could you please add description like in the doc string for InstanceNorm and
LayerNorm, specify the formula used for normalizing the input, and add a link
to the paper - https://arxiv.org/pdf/1803.08494.pdf. And add test for this
change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
