mseth10 commented on a change in pull request #12884: [WIP] adding unittest for
MKLDNN softmax operator
URL: https://github.com/apache/incubator-mxnet/pull/12884#discussion_r226808507
##########
File path: tests/cpp/operator/mkldnn.cc
##########
@@ -1306,6 +1326,97 @@ void TestOpEx(const OpAttrs &forward_attrs, const
OpAttrs &backwards_attrs) {
}
}
+// compares output of fcompute with fcomputex
+void TestSoftmaxOp(const OpAttrs &forward_attrs) {
Review comment:
Yes, I plan to reuse TestOpEx and remove TestSoftmaxOp. I implemented it as
a separate function just for POC to verify my logic. Forgot to mention it in
the description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
