D-Roberts opened a new pull request #12896: Fix typo in formula in docstring for GRU cell and layer and add clarification to description (gluon.rnn) URL: https://github.com/apache/incubator-mxnet/pull/12896 ## Description ## There was a typo in the docstring formula for GRU in both rnn_cell.py and rnn_layer.py. Furthermore, I added a brief explanation of how the implementation is different from the original Cho 2014. ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items for your PR. - [ ] Changes are complete (i.e. I finished coding on this PR) - [ ] All changes have test coverage: - Unit tests are added for small changes to verify correctness (e.g. adding a new operator) - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore) - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL) - [ ] Code is well-documented: - For user-facing API changes, API doc string has been updated. - For new C++ functions in header files, their functionalities and arguments are documented. - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html - [ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change ### Changes ### - Fix formula in docstring for GRUCell in mxnet.gluon.rnn.rnn_cell.py - Add clarification to description of implementation - Fix formula in docstring for GRU layer in mxnet.gluon.rnn.rnn_layer.py - Add clarification to description of implementation. ## Comments ## - this is a small change that came up in GRU application by user. No Jira issue.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
