ashokei commented on a change in pull request #12502: [NGRAPH] MXNet - nGraph 
initial integration
URL: https://github.com/apache/incubator-mxnet/pull/12502#discussion_r227075562
 
 

 ##########
 File path: src/ndarray/ndarray.cc
 ##########
 @@ -733,6 +739,21 @@ void NDArray::UpdateMKLDNNMemDesc() {
 }
 #endif
 
+#if MXNET_USE_NGRAPH == 1
+std::shared_ptr<ngraph::runtime::TensorView> &NDArray::create_tensor_view() {
 
 Review comment:
   mainly for perf. reasons, but RVO may optimize this away will change to 
return by value.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to