nswamy commented on issue #12690: [MXNET-1000] get Ndarray real value and form it from a NDArray URL: https://github.com/apache/incubator-mxnet/pull/12690#issuecomment-432658538 @yzhliu my concerns are: 1) that we are exposing helper utility functions as public API. I am not convinced how printing binary float values would make sense except when you probably are dealing with a 2 or 3 dimensional tensor when axes have small values, i don't think I can find a difference if there is a pixel value different in [3x224x224] Image represented in NDArray. 2) Typically Java object's toString() do not print the binary content of an object - if you print binary content IMO could be very surprising to users. I gave an analogy above how BufferedImage does not print its pixel values in toString. Hence I suggested to only print the metadata of NDArray in toString() and move this helper to a utility class. Lastly look at what other frameworks are doing in their Tensor's toString() https://www.tensorflow.org/api_docs/java/reference/org/tensorflow/Tensor.html#toString()
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
